Add inline code comments on commits (#4898) #35589
Open
+333
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
This feature enables users to add inline code comments on individual commits, similar to the existing PR code review functionality. Comments can be added, edited, and deleted on any line of a commit's diff. Changes: - Add service layer functions for commit comment CRUD operations - Add router handlers and API routes for commit comments - Add model queries to find commit comments - Update diff templates to show comment UI on commit pages - Load and display commit comments in the Diff() handler - Reuse existing PR comment templates and JavaScript Implements: go-gitea#4898
ktamas77
force-pushed
the
feature/commit-inline-comments
branch
from
dfbfd56 to
a706a04
Compare
|
I don't think the comment type |
Instead of reusing CommentTypeCode (which is for PR code comments), introduce a new CommentTypeCommitCode type specifically for inline comments on commits. This provides better separation of concerns and makes the codebase more maintainable. Changes: - Add CommentTypeCommitCode constant and string representation - Update comment type methods to support the new type - Update all commit comment functions to use CommentTypeCommitCode - Handle commit comments separately in updateCommentInfos
Good point! I've updated the implementation to use a separate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements inline code comments on individual commits, similar to the existing PR code review functionality.
Features
Implementation Details
Commentmodel infrastructure (CommitSHA, Line, TreePath already supported)/commit/:sha/commentsfor create/update/deletePageIsCommitis trueTesting
Fixes #4898
/claim #4898